hzeller / rpi-rgb-led-matrix

Controlling up to three chains of 64x64, 32x32, 16x32 or similar RGB LED displays using Raspberry Pi GPIO
GNU General Public License v2.0
3.63k stars 1.15k forks source link

Method to declare panel arrangements for custom transformers as command line arguments #200

Closed jwheare closed 7 years ago

jwheare commented 8 years ago

e.g. I have 6 64x32 panels arranged in an upside down U chain. It would be great if I could specify that arrangement through command line arguments, to avoid the need to write a custom transformer and then hack led-image-viewer to accept it. I also notice you removed the -L transformer option (though it's still mentioned here: https://github.com/hzeller/rpi-rgb-led-matrix/tree/master/examples-api-use)

Maybe something like a text file that shows the arrangement in ASCII, that can be parsed by the standard command line options. So for my chain of 6 it looks like this:

64x32
4 3
5 2
6 1
hzeller commented 8 years ago

I have re-added the -L now (it was indeed lost in the process of cleanup). Please let me know if things now work again as before (though I guess for you chain of 6 you anyway need some other transformer).

I like the idea for defining the arrangement as text-file (implementation: a transformer that takes a text-file), but didn't get around implementing something like that yet.

But, let's put it this way, I accept pull requests :)

ChazUK commented 8 years ago

Would it not be better to use an array or object rather than just a plain text file? Possibly add this into the Makefile? This could then include orientation of the screens as well.

BennoG commented 7 years ago

In my library I use an XML file to discribe the configuration. So no recompilation needed for what kind of layout you use. (even timing and inversions are configurable from the XML) Also in this way you can support different PCB layouts without recompileing and differend HUB connections e.g. HUB8 and HUB12 and the HUB75 uesed by this project. I do use PWM output as soon as the enable is connected to the PWM pin otherwise i use timed enable output. hubConfig.zip

Benno