search

hzeller / rpi-rgb-led-matrix

Controlling up to three chains of 64x64, 32x32, 16x32 or similar RGB LED displays using Raspberry Pi GPIO
GNU General Public License v2.0
3.69k stars 1.17k forks source link

Outdated warning for adafruit installer? #801

Closed marcmerlin closed 5 years ago

marcmerlin commented 5 years ago

README.md says "Switch the Pinout The Adafruit HAT/Bonnet uses this library but a modified pinout to support other features on the HAT. So they forked this library and modified the pinout there. However, that fork is ancient, so I strongly suggest to use this original library instead. You can choose the Adafruit pinout with a command line flag."

Their current installer gets GITUSER=https://github.com/hzeller REPO=rpi-rgb-led-matrix COMMIT=814b79b5696d32dd1140304b41a1ec0068bb271a

Looks like it grabs https://github.com/hzeller/rpi-rgb-led-matrix/commit/814b79b5696d32dd1140304b41a1ec0068bb271a which is not the latested, but fewer than 10 revs behind.

Worth updating the doc?

hzeller commented 5 years ago

Do you have a link to their page where they use the new library ? In the past, they used the library, but then modify the Makefile to set their HAT to the default.

marcmerlin commented 5 years ago

Yes, they tweak the build to default to their hat/bonnet https://learn.adafruit.com/adafruit-rgb-matrix-plus-real-time-clock-hat-for-raspberry-pi?view=all mentions

curl https://raw.githubusercontent.com/adafruit/Raspberry-Pi-Installer-Scripts/master/rgb-matrix.sh >rgb-matrix.sh
sudo bash rgb-matrix.sh

which does

if [ $QUALITY_MOD -eq 1 ]; then
        # Build then install for Python 2.7...
        make build-python HARDWARE_DESC=adafruit-hat-pwm
        make install-python HARDWARE_DESC=adafruit-hat-pwm
marcmerlin commented 5 years ago

But they've stopped shipping a very outdated version " Earlier versions of this guide used our own fork of this library. That’s deprecated now, but still available if you have existing code built atop it. Otherwise, use this installer script and latest code. "