search

hzeller / timg

A terminal image and video viewer.
GNU General Public License v2.0
1.91k stars 73 forks source link

Added auto-crop support for PDF sources. #131

Closed lromor closed 7 months ago

hzeller commented 7 months ago

Nice! Can you test with -W, -WU and -U as well ? Another test-case would be to run with the quarter-pixelation as it has an unusual internal aspect ratio -pq

This will verify if the current order of translate and scale works well.

hzeller commented 7 months ago

Ah, and looks like the CI discovered that the version on the CI does not yet have the bounding-box call. We might need to if-def that feature out depending on when the bounding-box first appeared using the POPPLER_MAJOR_VERSION, POPPLER_MINOR_VERSION macros.

hzeller commented 7 months ago

It looks like that boundinng box call appeared in 0.88. So maybe an #if POPPLER_CHECK_VERSION(0, 88, 0) ?

hzeller commented 7 months ago

Cool, merged!