hzlzh / Alfred-Workflows

Make your Alfred more powerful. (include Workflows, Extensions and Themes)
http://AlfredWorkflow.com/
1.04k stars 95 forks source link

Goo.gl no longer works #10

Closed kongd closed 8 years ago

kongd commented 9 years ago

Goo.gl no longer shortens links properly - I get nothing in my clipboard.

hzlzh commented 9 years ago

@kongd Google changed its api, I'll adjust it soon.

ddarbyson commented 9 years ago

Yup, Google isn't working.

ddarbyson commented 9 years ago

...is there anybody out there?

chevcast commented 9 years ago

I believe this is because the API now has usage restrictions. @hzlzh needs to register the app with the Google API Console and get back a token to send along with API requests.

image

chevcast commented 9 years ago

I took the liberty of registering an app with the Google API Console on my own account and changed the source appropriately on my fork of this repo. I've tested it and goo.gl works as expected.

This line was all that needed modified. I re-exported the workflow and checked it into the downloads directory on my fork. Anyone who wants it can download the updated workflow here: https://github.com/chevex/Alfred-Workflows/raw/master/Downloads/Shorten-URL.alfredworkflow

This is temporary until @hzlzh is able to get to it :)

sarkis commented 9 years ago

@chevex I found your comment after I already did the same as you :)

:+1: for the work around and detailed explanation

Also, you can just go into Alfred Workflows in Alfred and double click on script filter and update in place

ddarbyson commented 9 years ago

thanks @chevex for the explanation on how to fix this broken API, your fix works.

maxrothman commented 9 years ago

Still broken, if it's not going to be fixed (or if the author doesn't want to register an app to use by default) please just remove the goo.gl option.

chevcast commented 9 years ago

I don't want to step on any toes but I'm happy to take over this project if the author isn't interested any longer.

littke commented 8 years ago

@hzlzh Did you see that you got an offer for a new maintainer for this project? ^

chevcast commented 8 years ago

And I'm still open to maintaining it :)

It is open source so maybe I'll just re-host it anyway at this point.

hzlzh commented 8 years ago

@littke @chevex That's cool, you can send pull request to this repo or I can add you as maintainers if you like?

Since you've forked this repo, like this fix https://github.com/chevex/Alfred-Workflows/commit/dffcad65718028a1f9ae57f6ee97ea811d7619dc

chevcast commented 8 years ago

I would have sent a PR but I generated my own token and figured you would want to do the same for Google yourself. I suppose it probably doesn't matter either way. I can submit a PR with my token in it

chevcast commented 8 years ago

I also would not mind being added as a maintainer and I'm happy to keep things up-to-date :-)

chevcast commented 8 years ago

Sorry, I apparently did not see the notification for your comment but only for the closing of the issue

hzlzh commented 8 years ago

A PR would be best, also you can add your googl token in the workflow, thanks for your support. :)