hzqst / MetaHookSv

MetaHook (https://github.com/nagist/metahook) porting for SvEngine (GoldSrc engine modified by Sven-Coop)
MIT License
149 stars 38 forks source link

Would prefer MSAA over Deferred Shading #264

Open JH828 opened 1 year ago

JH828 commented 1 year ago

Hello, anyone agree? Why not have r_msaa turn off r_light_dynamic automatically, and vice versa?

hzqst commented 1 year ago

good idea

JH828 commented 1 year ago

Thanks. And if for instance a cfg set both on (r_msaa 16; r_light dynamic 1 for example), they would both be turned off.

hzqst commented 1 year ago

Thanks. And if for instance a cfg set both on (r_msaa 16; r_light dynamic 1 for example), they would both be turned off.

Forgot to mention that the traditional MSAA technique won't work with deferred shading, that's why I introduced FXAA into renderer

JH828 commented 1 year ago

That's why we could have the choice of one over the other rather than sacrifice MSAA altogether. MSAA gives higher visual quality than FXAA. IMO, if r_msaa worked only with r_light_dynamic set to 0, so be it. If it's possible of course.