hzqst / MetaHookSv

MetaHook (https://github.com/nagist/metahook) porting for SvEngine (GoldSrc engine modified by Sven-Coop)
MIT License
149 stars 38 forks source link

Visual artifacts on the latest update #319

Closed H3ADROOM closed 10 months ago

H3ADROOM commented 1 year ago

I've downloaded latest MetaHookSv version (MetaHookSv-refs/tags/v20230925b) and in game I have artifacts. I will provide screenshots below. Issue is present on different PCs. Tested on NVIDIA Quadro T1000 and NVIDIA RTX 3070.

225840_20230925180755_1 225840_20230925180951_1 225840_20230925180855_1

hampta commented 1 year ago

Same issues

hzqst commented 1 year ago

Can't repro this issue with my 4060 laptop. Could you please provide more detailed information, like runtime environment (Windows or wine or proton) and the map? btw you could try r_gamma_blend 0 and gl_bindless 0

H3ADROOM commented 1 year ago

I run Windows 11. Issue is present on almost any map that has effects. Best examples would be "ka_cbp_b03" and "ka_risingsun". Another issue is that transparency is screwed. In spots where something should be hollow - it is completely black. gl_bindless 0 doesn't change anything for me, but r_gamma_blend 0 certanily does, pixelated artifacts are gone, transparency is still broken though.

H3ADROOM commented 1 year ago

Here are some screenshots that show transparency issue

225840_20230926130826_1 225840_20230926130116_1 225840_20230926125704_1

H3ADROOM commented 1 year ago

With r_gamma_blend 0 225840_20230926125655_1 Without r_gamma_blend 0 225840_20230926125658_1

hzqst commented 1 year ago

Here are some screenshots that show transparency issue

225840_20230926130826_1 225840_20230926130116_1 225840_20230926125704_1

The transparent issue was fixed in https://github.com/hzqst/MetaHookSv/releases/tag/v20230926a

H3ADROOM commented 1 year ago

The transparent issue was fixed in https://github.com/hzqst/MetaHookSv/releases/tag/v20230926a

Hmmmm, this release has a false positive for Trojan:Win32/Wacatac.H!ml

H3ADROOM commented 1 year ago

I won't force you to hurry up, but are there any updates on the artifacts? Transparency issue is gone, it works fine. As I said r_gamma_blend 0 removes those artifacts, but bloom is not present anymore.

hzqst commented 1 year ago

I won't force you to hurry up, but are there any updates on the artifacts? Transparency issue is gone, it works fine. As I said r_gamma_blend 0 removes those artifacts, but bloom is not present anymore.

I have no idea what's going on with the artifacts as I can't repro the issue at all on my end. I've tested with latest commit on 4060 laptop, RX6800 and UHD770, no artifact was found.

SMGgoPrrrrrr commented 1 year ago

Hi I also get artifacts but only when enabling dynamic lights. I also have gl_bindless on 1 and r_gamma_blend on 1.

My specs idk Gtx 1660ti 6gb i5 10600kf 32gb ram a samsung ssd - lol

svencoop 2023-09-28 00-49-31

hzqst commented 1 year ago

Hi I also get artifacts but only when enabling dynamic lights. I also have gl_bindless on 1 and r_gamma_blend on 1.

My specs idk Gtx 1660ti 6gb i5 10600kf 32gb ram a samsung ssd - lol

svencoop 2023-09-28 00-49-31

Can you please try https://github.com/hzqst/MetaHookSv/releases/tag/v20230928d ?

SMGgoPrrrrrr commented 1 year ago

yeah np.... Just tried it and got the same results.

Edit: On a fresh install.

di57inct commented 1 year ago

EDIT: nvm shadow play is bugged on default game too

Confirming this issue on RTX 4080 with latest driver version 546.01

|index|api| plugin name| plugin version| | 0| v2| Gmcx_model_effect.dll| | | 1| v4| StudioEvents.dll| 2023-10-14T02:31:51| | 2| v4| BulletPhysics_AVX2.dll| 2023-10-14T02:29:54| | 3| v4| Renderer_AVX2.dll| 2023-10-14T02:31:36| | 4| v4| CaptionMod.dll| 2023-10-14T02:30:07|

image

For some reason it also glitches out the nvidia shadow play lol

https://github.com/hzqst/MetaHookSv/assets/3608544/bb115103-5d2c-4767-acce-3d0d1b6a3931

https://github.com/hzqst/MetaHookSv/assets/3608544/5b818896-034d-4f68-b93f-e683cdb80fe0

https://github.com/hzqst/MetaHookSv/assets/3608544/2c3f5325-a359-4e68-bb6d-08fb60619d0e

di57inct commented 1 year ago

image

di57inct commented 1 year ago

Problem not present in

|    1| v4|        StudioEvents.dll|     2023-09-18T17:02:17|
|    2| v4|  BulletPhysics_AVX2.dll|     2023-09-18T16:59:41|
|    3| v4|       Renderer_AVX2.dll|     2023-09-18T17:01:58|
|    4| v4|          CaptionMod.dll|     2023-09-18T16:59:58|
H3ADROOM commented 11 months ago

Issue is still present, even on the latest update from 8 hrs ago (v20231230a)

rbar1um43 commented 11 months ago

I have the same issue in Condition Zero) gtx 1060 6gb (v20240103a)

20240105114218_1

rbar1um43 commented 11 months ago

I get a lot of this artifacts especcially in Condition Zero Deleted Scenes.

20240105115014_1 20240105115019_1

hzqst commented 11 months ago

I get a lot of this artifacts especcially in Condition Zero Deleted Scenes.

20240105115014_1 20240105115019_1

try r_gamma_blend 0

rbar1um43 commented 11 months ago

I get a lot of this artifacts especcially in Condition Zero Deleted Scenes. 20240105115014_1 20240105115019_1

try r_gamma_blend 0

Yeah, problem solved. No more artifacts.

rbar1um43 commented 11 months ago

Parts of some models appear trasparent for some reason.

20240105121702_1 20240105121716_1 20240105122316_1 20240105122622_1 20240105122641_1

hzqst commented 10 months ago

Should've been fixed in https://github.com/hzqst/MetaHookSv/releases/tag/v20240114a

Tested on NVIDIA Geforce 4060M, Graphic Driver : 4.6.0 NVIDIA 528.92

previous

fixed