hzrd149 / nostrudel

A sandbox for exploring nostr
https://nostrudel.ninja/
MIT License
139 stars 43 forks source link

Deleting "About" Profile content sends event with old content #248

Open tepozoa opened 5 days ago

tepozoa commented 5 days ago

When editing the user profile, deleting everything from About and sending the event sends the previous content of the About box. Adding new content publishes the updated content, but attempting to completely remove it is the specific failure.

Testing note: if I open Amethyst and delete all the About content, nostrudel immediately refreshes to blank out the data. Adding a new item in nostrudel immediately adds it and sends the event, but immediately deleting the content without leaving the profile edit page sends the event with the old content. So it doesn't seem to matter if you were in Profile edit mode or not, happening on both a fresh load and re-edit of the data.

I used Firefox webdev panel to inspect the request sent to confirm I see nostrudel sending the event with the old data I meant to delete - it's showing code position nostr-provider.js:36:15 from the nos2x-fox signing extension receiving that data to sign with the "about" content incorrect. $0.02 hth! thanks.

hzrd149 commented 4 days ago

thanks for the heads up, I think I found the issue It was ignoring the "about" field if it was set to an empty string ""

should be fixed in the next version :+1: