hzwer / ICCV2019-LearningToPaint

ICCV2019 - Learning to Paint With Model-based Deep Reinforcement Learning
MIT License
2.25k stars 312 forks source link

import numpy as np for access to np.sqrt() on line 17 #10

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/hzwer/LearningToPaint on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./baseline/DRL/actor.py:15:9: F821 undefined name 'init'
        init.xavier_uniform(m.weight, gain=np.sqrt(2))
        ^
./baseline/DRL/actor.py:15:44: F821 undefined name 'np'
        init.xavier_uniform(m.weight, gain=np.sqrt(2))
                                           ^
./baseline/DRL/actor.py:16:9: F821 undefined name 'init'
        init.constant(m.bias, 0)
        ^
3     F821 undefined name 'init'
3

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.