i-RIC / iriclib

1 stars 3 forks source link

Codes related to using QFile::copy() is removed #14

Closed kskinoue0612 closed 7 years ago

kskinoue0612 commented 7 years ago

Because we now has fs::copy(), I think code related to QFile::copy() is needless anymore.

Let's remove code related to QFile::copy(), to make the code more clean.

scharlton2 commented 7 years ago

Hi Keisuke,

Missed unittests_cgnsfile/case_add_grid_and_result.cpp

diff --git a/unittests_cgnsfile/case_add_grid_and_result.cpp b/unittests_cgnsfile/case_add_grid_and_result.cpp
index 87525d2..5d65fff 100644
--- a/unittests_cgnsfile/case_add_grid_and_result.cpp
+++ b/unittests_cgnsfile/case_add_grid_and_result.cpp
@@ -1,10 +1,6 @@
 #include "macros.h"

-#if defined(HAVE_QT)
-#include <QFile>
-#else
 #include "fs_copy.h"
-#endif

 #include <cgnslib.h>
 #include <iriclib.h>
@@ -20,11 +16,7 @@ extern "C" {

 void case_addGridAndResult()
 {
-#if defined(HAVE_QT)
-       QFile::copy("case_nogrid.cgn", "case_grid_result.cgn");
-#else
        fs::copy("case_nogrid.cgn", "case_grid_result.cgn");
-#endif

        int fid;
        int ier = cg_open("case_grid_result.cgn", CG_MODE_MODIFY, &fid);

case_add_grid_and_result.zip

kskinoue0612 commented 7 years ago

Thanks Scott,

I've added your diff to the branch, and merged.