i-RIC / iriclib

1 stars 3 forks source link

Closes i-RIC/iriclib#15 #17

Closed scharlton2 closed 6 years ago

scharlton2 commented 7 years ago

Hi Keisuke,

I didn't implement cg_iRIC_Read_Sol_Cell_Count_Mul since it seemed to only duplicate what cg_iRIC_Read_Sol_Count_Mul did. I'll work on the documentation when everything is finalized.

Thanks, Scott

kskinoue0612 commented 6 years ago

Hi Scott,

Thank you for implementing the functions. This is something rather big, so give me some time for reviewing this.

Keisuke

kskinoue0612 commented 6 years ago

Hi Scott,

I've reviewed the commits. Now iriclib has test cases using not only ADF version CGNS files, but also HDF5 version CGNS files. Thanks, it is a good improvements.

I've made some changes, and commited to my repository:

https://github.com/kskinoue0612/iriclib/tree/issue-15

The changes I've made is:

Please check the modification, and if think OK, let me know.

Thanks, Keisuke

kskinoue0612 commented 6 years ago

Hi Scott,

If you think my rebased version branch is acceptable, please do the following operation. In the following code, I guess your repository is named "scott", and my repository is named "inoue" in your local environment.

git fetch inoue
git checkout issue-15
git reset --hard inoue/issue-15
git push scott issue-15 -f

I welcome your comments or modifications, if you have ideas about improvements,

Thanks, Keisuke

scharlton2 commented 6 years ago

Hi Keisuke,

Everything looks good. I've done what you've asked so you can close the pull request if you want.

Thanks, Scott