search

i-RIC / iriclib

1 stars 3 forks source link

Closes i-RIC/iriclib#18 #19

Closed kskinoue0612 closed 6 years ago

kskinoue0612 commented 6 years ago

This closes issue #18.

Please note that this is the "first step". I mean, when this issue is fixed, we have to use FileLocker to lock Case1.cgn.lock not only in solvers, but also in iRIC GUI too, to make the "locking" framework works correctly.

I'll engage that issue in iRIC GUI, when this pull request is merged.

scharlton2 commented 6 years ago

Hi Keisuke,

Please see my pull request on kskinoue0612/iriclib

Scott

kskinoue0612 commented 6 years ago

Hi Scott,

I've merged your pr. I think it is OK now, so please merge pull request.

Keisuke

kskinoue0612 commented 6 years ago

Hi Scott,

Please do not merge this pull request, because I've noticed that maybe the implementation is not complete yet.

I'll look into the issue, and when it become clear, I'll share the information.

Thanks, Keisuke

kskinoue0612 commented 6 years ago

Hi Scott,

I've figured out the issue, and added two unit case programs:

To make the unit tests pass, FileLocker implementation is updated. README.md in unittest_cg_open_modify folder describes how to do the unit tests.

Please check them, and if the unit test passes on your environment, please merge the pull requests.

When you have questions or comments, please let me know.

Thanks, Keisuke

scharlton2 commented 6 years ago

Hi Keisuke,

I wasn't able to get the 2e41ae1 version to fail. I think what may have happened with your testing (because it happened to me today) was that maybe unittest_cg_open_modify/unittest_cg_open_read was loading an older iriclib.dll.

I've made a pr (kskinoue0612/iriclib#2) that fixes a few things for the cmake version.

Thanks, Scott