Closed kskinoue0612 closed 6 years ago
Hi Scott,
Thanks for reviewing and sending a pull request.
I've been not careful about CMakeList.txt because I usually use qmake for building. I'll be careful next time.
I've reviewed your pull request and merged, and after that, replaced case_initread.cgn.
The reason is that the case_initread.cgn you've registered was the older version of case_init.cgn, that has BaseIterativeData_t node, but not calculation result. I think we'd better use a CGNS file that contains calculation results, as the input of case_InitReadSuccess().
The new case_initread.cgn is the case_solstd.cgn after running case_SolWriteStd_adf(), that contains 5 calculation results. case_InitReadSuccess() passes with the new CGNS file too.
Thanks, Keisuke
Hi Keisuke,
Here's the script I use to build/test/debug iriclib with cmake: iriclib.zip
I just put them into the same directory as iricdev and checkout the iriclib branch I'm testing in lib\src\iriclib. The project is built and tested in lib\src\iriclib\_build.
Thanks, Scott
Hi Scott,
This is the pull request to fix issues #20, #23, #24, #25.
The final objective was to fix #20, but in the process I've found several issues, and fixed. I think it will be a good timing to start working on issue #27, after merging this pull request.
Thanks,
Keisuke