search

i-RIC / iriclib

1 stars 3 forks source link

started branch to demonstrate issue-25 from i-RIC/iriclib_v4 #92

Closed scharlton2 closed 2 years ago

scharlton2 commented 2 years ago

Hi Keisuke,

This was added in order to compare with the i-RIC/iriclib_v4 issue-25 branch. See i-RIC/iriclib_v4#25.

I didn't merge it just so that you would know about it.

Thanks, Scott

kskinoue0612 commented 2 years ago

Hi Scott,

Thank you for your contact. Please let me make sure about the situation.

Currently, the unit tests you added fail, and I guess you are going add modification to iriclib so that unit tests pass. Am I correct?

Thank you,

Keisuke

2021年12月15日(水) 9:45 Scott Charlton @.***>:

Hi Keisuke,

This was added in order to compare with the i-RIC/iriclib_v4 issue-25 branch. See i-RIC/iriclib_v4#25 https://github.com/i-RIC/iriclib_v4/issues/25.

I didn't merge it just so that you would know about it.

Thanks, Scott

You can view, comment on, or merge this pull request online at:

https://github.com/i-RIC/iriclib/pull/92 Commit Summary

File Changes

(6 files https://github.com/i-RIC/iriclib/pull/92/files)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/i-RIC/iriclib/pull/92, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6YIUOV7PMG7XD4P63OOFDUQ7QL7ANCNFSM5KCKP2AQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

scharlton2 commented 2 years ago

Hi Keisuke,

Yes, the branch https://github.com/scharlton2/iriclib/tree/develop_v4-issue-25-2013 is based on CGNS and everything should pass. The branch https://github.com/i-RIC/iriclib_v4/tree/issue-25 (based on hdf5 -- which I forgot to push yesterday, sorry) contains a unit test that fails -- case_GridRead_FaSTMECH_3d_results() in unittests_cgnsfile/case_grid.cpp.

Thanks, Scott

kskinoue0612 commented 2 years ago

Hi Scott,

Thank you for your explanation, and I'm sorry to be late. I've understood.

Thanks,

Keisuke