Closed TLNA114514 closed 5 months ago
Hi! Thank you very much for your contribution! I'll review this PR in a few days. I've noticed that this is your first contribution. I'll add you to the contributor list once the pull request is accepted.
Sorry for replying so late, for I didn't frequently check my outlook. The correct course code is ECON1101. I typed the wrong number at the beginning. I'm sorry for the mistake I had taken and the inconvenience I might bring to you. 发自 Outlookhttp://aka.ms/weboutlook
发件人: Haoyi Wu @.> 发送时间: 2024年1月29日 19:14 收件人: i-TechX/iTechX @.> 抄送: TLNA114514 @.>; Author @.> 主题: Re: [i-TechX/iTechX] add ECON1101 (PR #106)
@why-in-Shanghaitech commented on this pull request.
In courses/ECON1101/meta.jsonhttps://github.com/i-TechX/iTechX/pull/106#discussion_r1469440180:
@@ -0,0 +1,18 @@ +{
- "code": "ECON1101",
Confirmed from LRChttps://lrc.shanghaitech.edu.cn/course-detail?course_id=1323082, the course code ECON1101 is correct.
― Reply to this email directly, view it on GitHubhttps://github.com/i-TechX/iTechX/pull/106#discussion_r1469440180, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCY2DD2UI2Q7TZMTMAPAGQTYQ6ACNAVCNFSM6AAAAABCNAH2DWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBYGQZDIOBUG4. You are receiving this because you authored the thread.Message ID: @.***>
The names of the instructor and TA are right. Thank you for your correction!
发自 Outlookhttp://aka.ms/weboutlook
发件人: Haoyi Wu @.> 发送时间: 2024年1月29日 19:10 收件人: i-TechX/iTechX @.> 抄送: TLNA114514 @.>; Author @.> 主题: Re: [i-TechX/iTechX] add ECON1101 (PR #106)
@why-in-Shanghaitech commented on this pull request.
Waiting for author response...
In courses/ECON1101/meta.jsonhttps://github.com/i-TechX/iTechX/pull/106#discussion_r1469432620:
@@ -0,0 +1,18 @@ +{
- "code": "ECON1101",
From the slides, I've noticed that the course code is ECON1001. Which one is correct?
In courses/ECON1101/meta.jsonhttps://github.com/i-TechX/iTechX/pull/106#discussion_r1469434829:
@@ -0,0 +1,18 @@ +{
- "code": "ECON1101",
- "name": "Introduction to Economics: Energy and Environmental Economics\t",
- "semesters": [
- {
- "season": "Fall",
- "year": "2023",
- "course_id": "ECON1101.01",
- "department": "信息科学与技术学院",
- "credit": "3",
- "hours": "48",
- "prerequisite": "无",
- "evaluation": "20% homework + 15% quiz + 15% midterm + 50% final",
- "teacher": [],
I've noticed that the instructor is Xiyi Yang and the TA is Dong Zhang. Is this correct? If you could confirm this info, I could fix the teacher and ta lists for you.
― Reply to this email directly, view it on GitHubhttps://github.com/i-TechX/iTechX/pull/106#pullrequestreview-1848412885, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCY2DD7CZFASHRXOVFAZGYTYQ57TPAVCNFSM6AAAAABCNAH2DWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBYGQYTEOBYGU. You are receiving this because you authored the thread.Message ID: @.***>
Add a new course