search

i-TechX / iTechX

iTechX: Open source, edX-style, free course sharing platform.
https://i-techx.github.io
MIT License
33 stars 74 forks source link

add CS131 #39

Closed victoryang00 closed 2 years ago

why-in-Shanghaitech commented 2 years ago

Thank you for your contribution. It seems that you've done a lot on this project!

Unfortunately, there are several boilers in your commit:

  1. People images should only end with '.jpg';
  2. When you want to show new people in semesters, you should first add them to the people database (people/meta.json). Otherwise, they won't show up. (for each person, 'name' is required, others are optional)

Since I am developing a simple UI for metadata management, you have 2 choices:

  1. Fix this up based on your current commit. I'll merge this pull request once you've done that;
  2. Wait for me to finish up my UI system. Things might be easier, but you have to wait for several weeks (hopefully).
victoryang00 commented 2 years ago

the second choice may be better. I'm just the trailor of piazza.

victoryang00 commented 2 years ago

By the way, grabbing img from oa.shanghaitech.edu.cn is too ugly for me, so my policy is to make my img better than that.

victoryang00 commented 2 years ago

Will conrinuosly push CS224 Software Analysis and CS225 Distributed System after guaduation.

why-in-Shanghaitech commented 2 years ago

Hi, I've uploaded the playground codes for alpha testing. Welcome to visit this link.

There should be something wrong with your current setting: some people are not showing. Add them back and type the same ID should fix this. Or you can destroy your repo and fork a new one (recommended).

Also you need to manually rename '.png' to '.jpg'.

Tell me if you encounter any problems. Not all codes are thoroughly tested.

why-in-Shanghaitech commented 2 years ago

It seems that you haven't finished yet?

Some problems:

  1. Several images and people ids are wrong (sp17).
  2. Please use lower-case letters as people id.
  3. Do not introduce dummy files (I notice that you add yangyw.png without using it).
  4. Use your own image instead of an avatar.
  5. It has caused conflicts since I'm maintaining CS274A this semester.

I think it is not easy for you to do 2, 3 since they can't get fixed in the browser by now. Some choices:

  1. Fix 1-4 and I'll resolve the conflict;
  2. Destroy the repo and fork again;
  3. Ask me to fix the problems for you. I should be able to add commits to your branch now. If you choose this, fix 1 first since I don't know the names of the TAs.
why-in-Shanghaitech commented 2 years ago

I manually merged this branch... I'll close this pull request. Thank you for your contribution.