i-VRESSE / workflow-builder

Graphical interface to build a workflow file
https://i-vresse-workflow-builder.netlify.app/
Apache License 2.0
3 stars 2 forks source link

Use molecule filename as index #110

Closed sverhoeven closed 2 years ago

sverhoeven commented 2 years ago

Fixes #57 Fixes #76

TODO

Previous PR #104 was merged prematurly, this PR continues work.

To test:

  1. In haddock3-download app
    1. upload pdb file into global parameters
    2. Add mdref node
    3. In form of mdref expand molecules subform
    4. Press + button on mol_shape parameter
    5. The filename of the uploaded pdb file should show as first column
  2. In storybook of form package yarn storybook + http://localhost:6007/
    1. The Array and TableField have stories with indexes.

Due to formatting with prettier and yarn lint --fix there are changes that are not relevant.

netlify[bot] commented 2 years ago

Deploy Preview for wonderful-noether-53a9e8 ready!

Name Link
Latest commit 918f5e655cbb16f83e9211be563ef06759c71ea5
Latest deploy log https://app.netlify.com/sites/wonderful-noether-53a9e8/deploys/62f366e3d4cf250009b202fd
Deploy Preview https://deploy-preview-110--wonderful-noether-53a9e8.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 2 years ago

Codecov Report

Merging #110 (c73a9da) into main (32cc0da) will increase coverage by 2.77%. The diff coverage is 86.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   61.29%   64.06%   +2.77%     
==========================================
  Files          55       56       +1     
  Lines        3741     3974     +233     
  Branches      275      317      +42     
==========================================
+ Hits         2293     2546     +253     
+ Misses       1444     1426      -18     
+ Partials        4        2       -2     
Flag Coverage Ξ”
core-unit 60.36% <86.60%> (+3.57%) :arrow_up:
form-unit 78.47% <84.09%> (+0.66%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
packages/core/src/store.ts 75.88% <43.47%> (+3.25%) :arrow_up:
packages/form/src/ArrayFieldTemplate.tsx 74.41% <63.15%> (+0.47%) :arrow_up:
...ackages/core/src/molecule/addMoleculeValidation.ts 92.81% <93.28%> (+1.14%) :arrow_up:
packages/core/src/NodeForm.tsx 44.44% <100.00%> (+44.44%) :arrow_up:
packages/core/src/molecule/parse.ts 92.10% <100.00%> (+2.81%) :arrow_up:
packages/core/src/validate.ts 97.77% <100.00%> (+0.05%) :arrow_up:
packages/form/src/table/TableFieldTemplate.tsx 71.69% <100.00%> (-0.36%) :arrow_down:
packages/form/src/useIndexable.tsx 100.00% <100.00%> (ΓΈ)
sverhoeven commented 2 years ago

Thanks for reviewing.

Good suggestion about position, I moved the index label to the top when the children are an object or array.