search

i-VRESSE / workflow-builder

Graphical interface to build a workflow file
https://i-vresse-workflow-builder.netlify.app/
Apache License 2.0
3 stars 2 forks source link

Add postprocess: true to catalogs #124

Closed sverhoeven closed 1 year ago

sverhoeven commented 1 year ago

To get plotting the postprocess option should be added to the workflow. The default value needs to be true, as we want plots by default. See https://github.com/haddocking/haddock3/issues/614

sverhoeven commented 1 year ago

At https://github.com/i-VRESSE/workflow-builder/blob/main/packages/core/src/store.ts#L195 fields with a same value as default from the catalog are pruned. The posprocess field should be kept even it is is equal to the default.

The prune function should be made smarter, for example if field is required then keep it. Or alternatively make it part of https://github.com/i-VRESSE/bartended-haddock3/issues/11

sverhoeven commented 1 year ago

Marking it required forces any archive uploaded to the builder to have a postprocess parameter set.

This makes the all the workflow config files in https://github.com/haddocking/haddock3/tree/main/examples invalid when uploaded to the builder. As they are run with haddock3 cli where postprocess parameter is optional and defaults to false.

sverhoeven commented 1 year ago

Dont treat preprocess different

It is enforced at https://github.com/i-VRESSE/bartended-haddock3/blob/9600aa2cf13753c21ac175bf4680adc97d7190ca/app/models/applicaton.server.ts#L67