Closed dmijatovic closed 6 months ago
Name | Link |
---|---|
Latest commit | 41b32a2043c139d30ce61e1dd23746d1662c9793 |
Latest deploy log | https://app.netlify.com/sites/i-vresse-workflow-builder/deploys/65f2daff0bcbb10008705b07 |
Deploy Preview | https://deploy-preview-139--i-vresse-workflow-builder.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Attention: Patch coverage is 18.18182%
with 45 lines
in your changes are missing coverage. Please review.
Project coverage is 67.04%. Comparing base (
7206c03
) to head (41b32a2
). Report is 1 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
The download button disappears under the page fold when the form gets expanded a lot. while before a scrollbar was shown around the form/catalog/workflow. In the hadock3 webapp the button row floats. Having the least amount of scrollbars is I think my preference, Not sure if the button row should be sticky or get pushed down. What do you think?
Maybe we can move the global parameters to be first item in the workflow list (without the option for move and delete) and then have three workflow buttons at the top: Upload, Download and Clear. For the "node" buttons (save, delete and cancel) we could implement some basic "auto save" approach and remove the buttons. Delete option is present in the list but we loose the cancel option in this case.
Based on the feedback from users of haddock web app and the investigation performed in this issue it is been decided to remove css-in-js styles from core library. Instead, the specific classes are added which can be used for customization
btn-catalog-node
,btn-visual-node
,btn-visual-panel
.It was not possible to completely remove @emotion dependency. There were build errors with the storybook components. I moved @emotion to devDependencies for now.
After removing styles from core lib, the (example) download app styles are extended. Additional (similar) work might be needed in the other apps (I have not checked it actually).
Example download app (with changed styles)