i-VRESSE / workflow-builder

Graphical interface to build a workflow file
https://i-vresse-workflow-builder.netlify.app/
Apache License 2.0
3 stars 2 forks source link

Haddock3 webapp test fail #164

Closed sverhoeven closed 3 weeks ago

sverhoeven commented 3 weeks ago

Due to #160 fixes.

 FAIL  app/models/application.server.test.ts > rewriteConfigInArchive() > plot_matrix should be set to true for clustfcc and clustrmsd modules
Error: Invalid workflow
 ❯ validateWorkflowAgainstExpertiseLevels app/models/applicaton.server.ts:263:9
    261|     }
    262|   }
    263|   throw new ValidationError("Invalid workflow", errors);
       |         ^
    264| }
    265| 
 ❯ Module.rewriteConfigInArchive app/models/applicaton.server.ts:228:3
 ❯ app/models/application.server.test.ts:175:20

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { errors: [ { message: 'must have node name belonging to known nodes', params: { node: 'less_io' }, instancePath: '', schemaPath: '', keyword: 'schema', workflowPath: 'nodes[2]' } ] }
sverhoeven commented 3 weeks ago

Error changed to

 FAIL  app/models/application.server.test.ts > rewriteConfigInArchive() > plot_matrix should be set to true for clustfcc and clustrmsd modules
Error: Invalid workflow
 ❯ validateWorkflowAgainstExpertiseLevels app/models/applicaton.server.ts:263:9
    261|     }
    262|   }
    263|   throw new ValidationError("Invalid workflow", errors);
       |         ^
    264| }
    265| 
 ❯ Module.rewriteConfigInArchive app/models/applicaton.server.ts:228:3
 ❯ app/models/application.server.test.ts:175:20

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { errors: [ { instancePath: '', schemaPath: '#/additionalProperties', keyword: 'additionalProperties', params: { additionalProperty: 'less_io' }, message: 'must NOT have additional properties', workflowPath: 'global' } ] }
sverhoeven commented 3 weeks ago

The download app is showing a '+' button on bottom of global parameters.

localhost_3000_

Which it should not do