fix(adapters): remove duplicated function definitions in interfaces - Githubissues

i-am-bee / bee-agent-framework

The framework for building scalable agentic applications.

https://i-am-bee.github.io/bee-agent-framework/

Apache License 2.0

1.09k stars 106 forks source link

fix(adapters): remove duplicated function definitions in interfaces #139

Closed akihikokuroda closed 2 weeks ago

akihikokuroda commented 2 weeks ago

Which issue(s) does this pull-request address?

No issue opened.

Description

There are duplicated function definitions in interfaces in adapters/ibm-vllm/types.ts. This PR remove them.

Checklist

[x] I have read the contributor guide
[x] Linting passes: yarn lint or yarn lint:fix
[x] Formatting is applied: yarn format or yarn format:fix
[x] Unit tests pass: yarn test:unit
[ ] E2E tests pass: yarn test:e2e
[ ] Tests are included
[ ] Documentation is changed or added
[x] Commit messages and PR title follow conventional commits

akihikokuroda commented 2 weeks ago

Thanks for comments! I overlooked the function names. There are 2 sets of the definitions. One with the as-is name and the other with the camelCase. https://github.com/grpc/grpc-node/blob/912beea1d92137349dbfeef28e16e49bf9ff3d4a/packages/proto-loader/bin/proto-loader-gen-types.ts#L558