search

i-and-t / frappe_docker

Docker images for production and development setups of the Frappe framework and ERPNext
MIT License
0 stars 0 forks source link

AWS Application load balancer healthcheck endpoint at erpnext-nginx #1

Open i-and-t-admin opened 3 years ago

i-and-t-admin commented 3 years ago

Is your feature request related to a problem? Please describe. I configured ERPNext docker-compose in AWS ECS without Traefik. There is few tweaks needed to use AWS ALB as load balancer. One particular point is, erpnext-nginx does not have a healthcheck end point, which cause ALB to terminate the erpnext-nginx ECS tasks.

Describe the solution you'd like Following snippet in frappe_docker\build\frappe-nginx\nginx-default.conf.template

location /health-check { access_log off; return 200 'A-OK!';

because default content-type is application/octet-stream,

# browser will offer to "save the file"...
# the next line allows you to see it in the browser so you can test 
add_header Content-Type text/plain;

}

Describe alternatives you've considered Add Traefik back between ALB and nginx (ALB --> Traefik --> Nginx)

Additional context I think Traefik is not required in the context of AWS ECS

i-and-t-admin commented 3 years ago

/cib