feature/simplify-dependencies - Githubissues

i-dot-ai / redbox

Bringing Generative AI to the way the Civil Service works

https://i-dot-ai.github.io/redbox/

MIT License

83 stars 27 forks source link

feature/simplify-dependencies #774

Closed gecBurton closed 1 month ago

gecBurton commented 1 month ago

Context

As an Engineer I want to simplify Settings driven attributes, i.e. we have a lot of objects that are:

entirely driven by the Settings
are singletons

We should make this relationship clearer

Changes proposed in this pull request

dependencies.get_elasticsearch_client deleted in favour of existing Settings.get_elasticsearch_client
dependencies.get_index_name deleted in favour of existing Settings.index_name
dependencies.get_embedding_model move to Settings.get_embedding_model
unused dependencies.get_vector_store deleted
unused dependencies.get_storage_handler deleted

out of scope

The following could /should be moved but the PR would blow up. One for another day?

dependencies.get_parameterised_retriever
dependencies.get_all_chunks_retriever
dependencies.get_llm

Guidance to review

Relevant links

Things to check

[ ] I have added any new ENV vars in all deployed environments
[ ] I have tested any code added or changed
[ ] I have run integration tests

gecBurton commented 1 month ago

deprecated in favour of https://github.com/i-dot-ai/redbox/pull/782