There was user feedback around feedback not being sent if there’s a network/VPN issue, and lack of error message.
I don’t think showing an error message is necessarily helpful in this case - at least not specific/locally to this. But we can try resending this data automatically, just to give it as much chance of being received as possible.
Changes proposed in this pull request
If sending feedback fails, try again in 10 seconds, up to 10 times.
Guidance to review
Check that the code looks sensible
You can test by getting a response, and then disconnecting from the network, checking the requests in dev tools. If you really want to.
Questions
I've plucked these numbers out of thin air (10 seconds, 10 attempts). Do they sound sensible?
Do we need a limit, or should we keep trying continuously (i.e. until successful or the page is reloaded)
Context
There was user feedback around feedback not being sent if there’s a network/VPN issue, and lack of error message.
I don’t think showing an error message is necessarily helpful in this case - at least not specific/locally to this. But we can try resending this data automatically, just to give it as much chance of being received as possible.
Changes proposed in this pull request
Guidance to review
Questions
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-607
Things to check