coveralls
commented
2 years ago Pull Request Test Coverage Report for Build 3262760136
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 173 of 176 (98.3%) changed or added relevant lines in 5 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.4%) to 97.525%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/hooks/useManagerTwo.ts | 153 | 156 | 98.08% | ||
| <!-- | Total: | 173 | 176 | 98.3% | --> |
| Totals | |
|---|---|
| Change from base Build 3233129098: | 0.4% |
| Covered Lines: | 1299 |
| Relevant Lines: | 1329 |
It's always been a bad pattern to copy props into state and this causes bugs like #7. This PR refactors the
useManager()hook and centralmanagerReducer()to remove all props passed into the component from the manager state.