Closed i-like-robots closed 2 years ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/hooks/useManagerTwo.ts | 153 | 156 | 98.08% | ||
<!-- | Total: | 173 | 176 | 98.3% | --> |
Totals | |
---|---|
Change from base Build 3233129098: | 0.4% |
Covered Lines: | 1299 |
Relevant Lines: | 1329 |
It's always been a bad pattern to copy props into state and this causes bugs like #7. This PR refactors the
useManager()
hook and centralmanagerReducer()
to remove all props passed into the component from the manager state.