i-like-robots / react-tag-autocomplete

⚛️ A simple, accessible, tagging component ready to drop into your React projects (new repo)
https://i-like-robots.github.io/react-tag-autocomplete/
ISC License
178 stars 12 forks source link

fix: Prevent closing combobox when click on scrollbar #34

Closed Tomas2D closed 1 year ago

Tomas2D commented 1 year ago

Resolves #33

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4074566342

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 3991164149: 0.0%
Covered Lines: 1303
Relevant Lines: 1326

💛 - Coveralls
i-like-robots commented 1 year ago

Thank you so much for opening this @Tomas2D but this solution changed the behaviour of the component (which is my bad for not making the tests tight enough.) I've added a fix which preserves the existing listbox behaviour and will release ASAP.

Tomas2D commented 1 year ago

@i-like-robots sure, no problem. Thanks!