coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 4520184390
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 99.011%
| Totals | |
|---|---|
| Change from base Build 4520031752: | 0.0% |
| Covered Lines: | 1352 |
| Relevant Lines: | 1362 |
One of the goals of this major release is to ensure terminology across the codebase and documentation is consistent and in alignment with any relevant ARIA specifications, in particular those for the combobox.
This PR updates two props which were out of line.
closeOnSelectcollapseOnSelectstartWithFirstOptionactivateFirstOptionI regret not making this change earlier, before the release candidate stage, but feel it must be done before this version is fully released and becomes more widely used. The current v6 release line gets ~30,000 downloads a week but v7 remains less than 300 so I feel comfortable that the impact of this change is limited.