search

i-like-robots / rewireify

Rewireify is a port of Rewire for Browserify that adds setter and getter methods to each module so that their behaviour can be modified for better unit testing.
https://www.npmjs.com/package/rewireify
Other
59 stars 10 forks source link

Using modules from upstream rewire #18

Open elicwhite opened 9 years ago

elicwhite commented 9 years ago

Instead of calling Object.defineProperty ourselves, we are using the upstream module for it.

Part of the discussion in #17

i-like-robots commented 9 years ago

Thanks for submitting this. I'm happy to use getDefinePropertySrc but I'm unsure what the effect of getImportGlobalsSrc is in a Browserify environment so I'll investigate. I believe global = window but I'll check it out and write a test or two.

elicwhite commented 9 years ago

Yeah, I truthfully didn't look that closely at that module either. Report back when you figure it out! :D

elicwhite commented 9 years ago

Any status on this? It's been a while.