i-net-software / dokuwiki-plugin-multiorphan

Administrative GUI to find all sorts of orphaned or wanted pages and media. This works using AJAX instead of loading everything into one page.
https://www.dokuwiki.org/plugin:multiorphan
5 stars 5 forks source link

Some false positives on missing media #25

Closed aubreyz closed 6 years ago

aubreyz commented 6 years ago

Great plugin - extremely useful and thanks for writing.

Missing media mis-identifies a small number - a few false positives.

a) In terms of standard syntax -- media referred to within footnotes (( )) are not detected

b) I can understand that some plugins might allow media to be used in strange ways and not identified as such. However at the very least media referred to in a completely standard form but within some other syntax wrapper should be picked up:

This is not picked up:

[{{ :case:case:20060519_student_press.jpg?direct&350 |20060519 Boucher in student press}}]

I see a previous report along these lines was closed -- but it should not have been. Footnoted media is never detected.

gamma commented 6 years ago

a) is fixed in b862bad

I'm, not sure what you want to accomplish in b) - is this part of a plugin? Which one?

aubreyz commented 6 years ago

Many thanks for fixing (a), gamma.

On (b), it happens to be from the imagebox plugin (but there will be many plugins that take completely standard syntax and wrap them in something simple). Whatever the case imagebox'ed media does not detect (or at least did not prior to your latest commit). I guess it might not be possible because you would not know for sure what the plugin does (for example it might comment-out a bit of code). Perhaps the user could specify a set of tags that are effectively stripped out of the code before checking?

Thanks again for all your work.

gamma commented 6 years ago

Note: for the checks of extra plugins there are two ways to have them included during the multi orphan check:

1) I need to update the checker which allows simple plugins to be included. 2) Plugin Authors can implement an event and check their syntax there.