reserved identifier violation

i-rinat / apulse

PulseAudio emulation for ALSA

MIT License

609 stars 35 forks source link

reserved identifier violation #4

Closed elfring closed 10 years ago

elfring commented 10 years ago

I would like to point out that identifiers like "APULSE__TRACE_H" and "APULSE__UTIL_H" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

i-rinat commented 10 years ago

But APULSE__TRACE_H doesn't have any leading or trailing underscores. Eh?

elfring commented 10 years ago

How do you think about to read corresponding information sources that describe the consequences of underscores in such identifiers?

i-rinat commented 10 years ago

Thanks for the links, they look interesting.

elfring commented 10 years ago

How do you think about to avoid that this software depends on undefined behaviour? Would you like to rename affected include guards?

i-rinat commented 10 years ago

As far as I understand, two consecutive underscored are reserved in C++ only. Since this project uses C solely, that's OK.

elfring commented 10 years ago

Would you like to support that your software can also be correctly processed by C++ compilers?

i-rinat commented 10 years ago

Nope.