Completion of error handling

i-rinat / apulse

PulseAudio emulation for ALSA

MIT License

609 stars 35 forks source link

Completion of error handling #5

Closed elfring closed 10 years ago

elfring commented 10 years ago

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

pthread_create ⇒ pa_threaded_mainloop_start
strdup ⇒ pa_stream_set_name

i-rinat commented 10 years ago

It's generally a good idea to check for errors, thanks for pointing this out.

However what this repository contains is "a hack". Large part of API is not implemented and most likely will not be implemented at all. So I think it's OK to leave it as it is.

elfring commented 10 years ago

I suggest to avoid ignorance of return values a bit more.

Are you interested to apply aspect-oriented software development? How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

elfring commented 10 years ago

How do you think about to improve static source code analysis also for your software?

Do you find information sources like the following useful?

Article "A Reusable Aspect for Memory Allocation Checking"
Document "Aspect-Oriented Software Development - An Introduction" by Johan Brichau and Theo D'Hondt
Paper "On Typesafe Aspect Implementations in C++" by Daniel Lohmann and Olaf Spinczyk