i-rinat / freshplayerplugin

ppapi2npapi compatibility layer
MIT License
728 stars 52 forks source link

video, audio is ok, but toolbar caption not seen #271

Closed kuh3h3 closed 9 years ago

kuh3h3 commented 9 years ago

i compiled ok git bad481deca5ba58bff5f4c7b65f0268b0f1b0ac2 version and copied library successfully with fedora 22 on x86 system.

sudo cp /home/reandr/freshplayerplugin/build/libfreshwrapper-pepperflash.so /usr/lib/mozilla/plugins/

but some build error with ffmpeg header redefinition occurred. so needed to comment out some line in some code.

src/pp_resource.h

//struct AVVDPAUContext { // VdpDecoder decoder; // VdpDecoderRender *render; // char reserved[256]; //};


src/ppb_video_decoder.c

//static inline AVFrame * //av_frame_alloc(void) //{ // return avcodec_alloc_frame(); //}


//static inline void //av_frame_free(AVFrame _frame) //{ // av_free(_frame); // frame = NULL; //}


//static //void //avcodec_free_context(AVCodecContext _pavctx) //{ // avcodec_close(_pavctx); // av_free(pavctx); // *pavctx = NULL;

//}

Generally work well on firefox,palemoon etc. video, audio is ok, but toolbar caption not seen. when click on toolbar location(for example stop), it work. but toolbar caption not seen.

working video,audio,caption(flash 11.2.202.521) http://i.imgur.com/iNNBCXi.png

not seen caption,working video,audio(flash 19.0.0.185) http://i.imgur.com/qfEMA9Q.png

what make this error ?

kuh3h3 commented 9 years ago

sorry, fixed by add enable_3d = 0 to freshwrapper.conf

i-rinat commented 9 years ago

Are you sure Flash is used at all? http://i.imgur.com/iNNBCXi.png looks like HTML5 player.

Youtube changed default player to HTML5 for Firefox 40 and more recent versions. It won't try to use Flash until HTML5 player fails to play anyhow.

kuh3h3 commented 8 years ago

what you mean? no html5. http://i.imgur.com/O5Z2HNY.png

i-rinat commented 8 years ago

HTML5 and Flash versions are slightly different. You can discern one from another just by looking on screenshot. Look at the timeline and buttons at the bottom of the player: comparison of HTML5 and Flash versions

Then look at your original screenshots. One of them is definitely HTML5. Other have no controls visible, so I can't tell. Version on screenshot in your recent comment https://github.com/i-rinat/freshplayerplugin/issues/271#issuecomment-146180291 is definitely Flash one.