i-rinat / freshplayerplugin

ppapi2npapi compatibility layer
MIT License
727 stars 52 forks source link

konqueror and freshplugin #291

Closed ROBERT-MCDOWELL closed 8 years ago

ROBERT-MCDOWELL commented 8 years ago

Hi Rinat,

just for info I tried to use freshplaerplugin with Konqueror KDE4 but apparently no flash is shown, only white page.

thanks

ROBERT-MCDOWELL commented 8 years ago

I'm not sure what you are talking about. I cloned already the master only

git checkout HEAD M 3rdparty/parson/Makefile Your branch is up-to-date with 'origin/master

I installed it today

i-rinat commented 8 years ago

git checkout HEAD

Not git checkout HEAD, but git checkout HEAD^. Notice that ^, it's crucial. HEAD is a special name for current commit, regardless where it is. HEAD^ is a name for a commit before current. HEAD^^ is a name for commit before HEAD^ and so on. That syntax applies to all names, so master^ is a commit before master.

I'm not sure what you are talking about.

There could be other changes, not only changes in freshwrapper. And latter could be unrelated to the issue at all. It's similar to rainmaking dance ritual. If one dances long enough, rain happens, but it's not caused by the ritual, it just happened after.

That's why it's worth to ensure that it's the recent changes in freshwrapper which fixed the issue.

However, it's just a matter of personal taste, of course.

ROBERT-MCDOWELL commented 8 years ago

ok my eyes where to tired yesterday. HEAD is now at d69440d... np_functions: store clipRect geometry

i-rinat commented 8 years ago

HEAD is now at d69440d... np_functions: store clipRect geometry

You are now at the point in time where no changes of rendering paths were made yet (previous changes were preparations only). Try to compile freshplayerplugin and test Flash in Konqueror again.

ROBERT-MCDOWELL commented 8 years ago

recompiled d69440d gives no flash shown in Konqueror. about:plugins shows Shockwave flash 19.0 r0 libfreshwrapper-flashplayer.so though

i-rinat commented 8 years ago

Ok, looks like recent changes had an effect indeed.

ROBERT-MCDOWELL commented 8 years ago

mmmhm, now I put the last git and the result is the same :( I just noticed that there was libfreshwrapper-pepperflash.so and libfreshwrapper-flashplayer.so in same time in plugin folder when it was working. but since I removed libfreshwrapper-pepperflash.so no flash is shown on pages

i-rinat commented 8 years ago

There was a patch that changed name to libfreshwrapper-flashplayer.so. Twitch.tv tested plugin name, and had unwanted behavior if there were "pepperflash" substring.

i-rinat commented 8 years ago

I think you had two versions of freshwrapper at the same time.

ROBERT-MCDOWELL commented 8 years ago

yes it's possible. but when I said it was working and you asked me to downgrade the git version I check the konqueror plugin configuration and libfreshwrapper-pepperflash was still marked... I'm confused.

ROBERT-MCDOWELL commented 8 years ago

There was a patch that changed name t yes I noticed it days ago. I just forgot to remove the old freshpepper before to test the new. anyhow fortunately I have another server with the exact copy and the 2 plugins were still there. so I tested with the 2 first and konqueror crashed. I removed freshpepper and installed the last git version freshwrapper-flashplayer, launch konqueror and everything is running flawlessly... so I guess my other server need a reboot to cleanup things in konqueror I guess

ROBERT-MCDOWELL commented 8 years ago

konqueror_flashplayer Rinat, I just checked something very unusual. I went on a web page from swfobject to test the flash player version with konqueror to see if anything is ok with freshplugin and stupor, it shows flash player version 11.2.2xx !! Knowing that I remove any official flash player from my hard drive so there is absolutely no trace of flashplayer 11.2 it's quiet unusual to get this result. I upgraded in Fedora 23 with last updates

attached a screenshot the link to test your swf version http://www.bobbyvandersluis.com/swfobject/testsuite_2_2/test.html

i-rinat commented 8 years ago

@madovsky, this string, with LNX and numbers divided by commas, is generated by Flash itself, so you definitely have libflashplayer.so somewhere.

I think grep flash /proc/$(pidof konqueror)/maps can help to locate which plugin is loaded into konqueror process.

ROBERT-MCDOWELL commented 8 years ago

I confirm that absolutely no trace of libflashplayer.so is on my system. here is all things there are in the proc folder. no trace of flash attr cwd loginuid ns root statm autogroup environ map_files numa_maps sched status auxv exe maps oom_adj schedstat syscall cgroup fd mem oom_score sessionid task clear_refs fdinfo mountinfo oom_score_adj setgroups timers cmdline gid_map mounts pagemap smaps uid_map comm latency mountstats personality stack wchan coredump_filter limits net projid_map stat

ROBERT-MCDOWELL commented 8 years ago

ok sorry I was not on a page with flash object here it is

[root@node228 ~]# grep flash /proc/64648/maps 7feebc145000-7feebd119000 r-xp 00000000 08:03 3146887 /opt/google/chrome/PepperFlash/libpepflashplayer.so 7feebd119000-7feebd319000 ---p 00fd4000 08:03 3146887 /opt/google/chrome/PepperFlash/libpepflashplayer.so 7feebd319000-7feebd3db000 r--p 00fd4000 08:03 3146887 /opt/google/chrome/PepperFlash/libpepflashplayer.so 7feebd3db000-7feebd40f000 rw-p 01096000 08:03 3146887 /opt/google/chrome/PepperFlash/libpepflashplayer.so 7fef2745c000-7fef274c0000 r-xp 00000000 08:03 918764 /usr/lib64/mozilla/plugins/libfreshwrapper-flashplayer.so 7fef274c0000-7fef276bf000 ---p 00064000 08:03 918764 /usr/lib64/mozilla/plugins/libfreshwrapper-flashplayer.so 7fef276bf000-7fef276c2000 r--p 00063000 08:03 918764 /usr/lib64/mozilla/plugins/libfreshwrapper-flashplayer.so 7fef276c2000-7fef276c4000 rw-p 00066000 08:03 918764 /usr/lib64/mozilla/plugins/libfreshwrapper-flashplayer.so

ROBERT-MCDOWELL commented 8 years ago

ok that's very odd, now it works [root@node228 ~]# grep flash /proc/64648/maps 7feebc145000-7feebd119000 r-xp 00000000 08:03 3146887 /opt/google/chrome/PepperFlash/libpepflashplayer.so 7feebd119000-7feebd319000 ---p 00fd4000 08:03 3146887 /opt/google/chrome/PepperFlash/libpepflashplayer.so 7feebd319000-7feebd3db000 r--p 00fd4000 08:03 3146887 /opt/google/chrome/PepperFlash/libpepflashplayer.so 7feebd3db000-7feebd40f000 rw-p 01096000 08:03 3146887 /opt/google/chrome/PepperFlash/libpepflashplayer.so 7fef2745c000-7fef274c0000 r-xp 00000000 08:03 918764 /usr/lib64/mozilla/plugins/libfreshwrapper-flashplayer.so 7fef274c0000-7fef276bf000 ---p 00064000 08:03 918764 /usr/lib64/mozilla/plugins/libfreshwrapper-flashplayer.so 7fef276bf000-7fef276c2000 r--p 00063000 08:03 918764 /usr/lib64/mozilla/plugins/libfreshwrapper-flashplayer.so 7fef276c2000-7fef276c4000 rw-p 00066000 08:03 918764 /usr/lib64/mozilla/plugins/libfreshwrapper-flashplayer.so

i-rinat commented 8 years ago

ok that's very odd, now it works

Linux keeps loaded libraries mapped even if you delete them. So it's possible for some process to have libflashplayer.so (NPAPI Flash) still loaded even if you uninstall it. As far as I know, KDE keeps its services running even if user closes all KDE apps. Older Flash could been cached somewhere in memory.

ROBERT-MCDOWELL commented 8 years ago

yes, its' what I guessed. anyhow the thing I don't lie on konqueror is everytime you must click on a button "start plugin" on the page... there is another thing I think konqueror crashes abviously (but must it crash?) if there is no sound card and you play a movie.

i-rinat commented 8 years ago

@madovsky, I don't think I get what you're saying.

if there is no sound card and you play a movie.

There is a special sound backend which provides synchronization events if no real sound sink available. Freshwrapper shouldn't crash in that case.

ROBERT-MCDOWELL commented 8 years ago

ok, so it must come from konqueror since it does not crash with firefox and chrome

i-rinat commented 8 years ago

Recent versions of freshwrapper call gdb to get a self-backtrace in case of a crashing. There should be text files in /tmp, with names starting with freshwrapper-backtrace. Perhaps there is still a bug in freshwrapper. But it also possible that freshwrapper tries to access parts of NPAPI that Konqueror not implement. In latter case nothing really could be done, as almost all used parts of NPAPI are required.

ROBERT-MCDOWELL commented 8 years ago

right, I attached all of these freshwrapper-backtrace-1450708329-653.txt freshwrapper-backtrace-1450652829-32194.txt freshwrapper-backtrace-1450652844-32238.txt freshwrapper-backtrace-1450653260-23703.txt

i-rinat commented 8 years ago

freshwrapper-backtrace-1450708329-653.txt

Crash was caused by X IO error. Those are unrecoverable errors of X11 protocol, which unconditionally lead to program termination. Something happened before, caused it. Hard to tell.

freshwrapper-backtrace-1450652829-32194.txt

Most probably this one was caused by missing NPN_PluginThreadAsyncCall method of NPAPI. From having nspluginviewer string in report, I can guess in that case libnsplugin.so was in use. It have no knowledge of plugins using additional threads. That's impossible to support.

freshwrapper-backtrace-1450652844-32238.txt

Same as in freshwrapper-backtrace-1450652829-32194.txt

freshwrapper-backtrace-1450653260-23703.txt

Crashing somewhere inside KDE libraries. Looks like KParts::BrowserExtension::setPageSecurity had broken pointer dereference? Can't tell.


Well. Couple of those crashed cannot be fixed. Flash has changed its working compared to times of libnsplugin.so. Other two are either unrelated to freshwrapper, or were caused by memory corruption (could be caused by any part, including freshwrapper). In latter case, backtraces are not informative, unfortunately.

ROBERT-MCDOWELL commented 8 years ago

ok I installed fedora 23 workstation with Gnome desktop on my laptop and usb stick 24Gb and after satisfied all dependencies freshplugin works very well on seamonkey, firefox and even epiphany. excellent job Rinat and I wish to you plenty of joy and success for 2016

i-rinat commented 8 years ago

wish to you plenty of joy and success for 2016

Thanks a lot!

ROBERT-MCDOWELL commented 8 years ago

as it works now on konqueror like other browsers I close the issue