search

i-rinat / freshplayerplugin

ppapi2npapi compatibility layer
MIT License
727 stars 52 forks source link

Update reported Flash version #351

Closed sarnex closed 7 years ago

sarnex commented 7 years ago

Some websites fail to load because freshplayerplugin reports a very old version of flash, even if my native flash install is high enough version. If I update these two strings, everything works fine.

Signed-off-by: Nick Sarnie commendsarnex@gmail.com

i-rinat commented 7 years ago

Isn't it better to have manifest.json file with an actual version alongside with libpepflashplayer.so?

sarnex commented 7 years ago

I don't think think so, this is a one time update because many websites want flash over version 15. If the users wants to set a specific version, they can use manifest.json, but if they just want things to work, the version should not be ancient.

i-rinat commented 7 years ago

they can use manifest.json

This file should be near libpepflashplayer.so. Chrome does that, and even Adobe now distributes PepperFlash with that file. That file is the only way to get plugin version by a browser, since PPAPI have no interface for that task.

I've merged the PR. But it can cause some additional confusion. Version 13.1.2.3 looked obviously wrong, that was intentional. Contrary, version 24.0.0.186 looks like a normal version, and will cause confusion when plugin version will change. One will see the same 24.0.0.186 despite plugin is actually newer.

Let's hope packagers do include manifest.json.