tables: include va_x11 only if HAVE_HWDEC

i-rinat / freshplayerplugin

ppapi2npapi compatibility layer

MIT License

727 stars 52 forks source link

tables: include va_x11 only if HAVE_HWDEC #385

Closed Hello71 closed 4 years ago

i-rinat commented 4 years ago

Thanks for the patch.

There was a small issue with the change. Since HAVE_HWDEC macro is always defined, ifdef always evaluate its truth branch. HAVE_HWDEC macro is either 0 or 1, so there should be if rather than ifdef. I've pushed change as 9130ce76efd0a40a974cc6ca1f0b0bc43bf9f820.

Github doesn't consider merge of a changed commit as a PR merge, so now you see a message about conflicts.

Hello71 commented 4 years ago

ah, I remember. I wrote this patch several months ago so I forgot since then. just got around to cleaning out my patches.

I think it is more common to use define/undef for feature macros, at least that's what autoconf supports. not really worth changing the whole project for it though.

thanks!