changeRecMode + OSC = crash

i-score-old / i-score

an interactive intermedia sequencer

www.i-score.org

23 stars 5 forks source link

changeRecMode + OSC = crash #38

Closed jcelerier closed 9 years ago

jcelerier commented 10 years ago

It looks like there is a crash when trying to set the rec mode for an OSC device.

Procedure :

Create an OSC device with a message.
Create a box.
Set the rec mode for the box.

It looks like QTreeWidgetItem *item = getItemFromAddress(address); returns a null pointer, in NetworkTree::setRecMode.

The crash disappears if a null pointer check is done, and the box turns red, however I don't know if doing this entirely disables recording mode?

jcelerier commented 10 years ago

This seems to be caused by the fact that only the first part of the OSC message seems to be registered in NetworkTree::_adressMap (i.e. only "newDevice" for "newDevice/OSCMessage0").

bltzr commented 10 years ago

Théo has been fixing stuff that might be related to this... can you check if the problem is still there ? Thanks.

bltzr commented 9 years ago

maybe we shouldn't allow to record unless a reception port was set for the device ?

bltzr commented 9 years ago

@theod any opinion about this ?

jcelerier commented 9 years ago

I've got it in 798f6ef