search

i-tu / Hasklig

Hasklig - a code font with monospaced ligatures
SIL Open Font License 1.1
5.56k stars 156 forks source link

No color on macOS Big Sur #123

Closed balupton closed 3 years ago

balupton commented 3 years ago
foxt commented 3 years ago

This seems to be an issue with a SVG table, we need someone to remove those from Hasklig to regain support

patricklewis commented 3 years ago

Took me a while to identify the font as the source of this "no text color" problem in Visual Studio Code after upgrading to Big Sur today.

hisham-blackbuck commented 3 years ago

any workarounds for this? Reinstalling Hasklig did not fix the issue, and while disabling Hasklig is the only workaround now, my code looks bland without Hasklig :cry:

thedocbwarren commented 3 years ago

Would love a solution. Appears other fonts work that have ligatures.

1moeses commented 3 years ago

Is there someone who can do a pull request. Unfortunally I'm not into python font coding stuff right now. The last commit was on Feb. 27, 2020.

thedocbwarren commented 3 years ago

Will need to build from the patched (remove SVG table) from Source Code Pro then add ligatures. I wish I did this these days as I use to make fonts, but not recently.

labikmartin commented 3 years ago

any workarounds for this? Reinstalling Hasklig did not fix the issue, and while disabling Hasklig is the only workaround now, my code looks bland without Hasklig 😢

You can use Source Code Pro in the meantime. Google Fonts

hisham-blackbuck commented 3 years ago

I believe Source Code Pro has slightly different ligatures. For example, the arrow function symbol is different. Correct me if I'm wrong here

labikmartin commented 3 years ago

I believe Source Code Pro has slightly different ligatures. For example, the arrow function symbol is different. Correct me if I'm wrong here

That font doesn't have ligatures. But other than that it looks the same :)

hisham-blackbuck commented 3 years ago

Oh then I'll have to wait till Hasklig fixes this, because I need those ligatures. I could try Fira Code in the meantime

tovbinm commented 3 years ago

Switching to Source Code Pro worked - https://github.com/adobe-fonts/source-code-pro/releases/tag/2.032R-ro%2F1.052R-it%2F1.012R-VAR

Looking forward for a similar fix for Hasklig!

thedocbwarren commented 3 years ago

Looking at last update I'd say this might be unmaintained. Not sure how this font was generated from Source Code Pro. I'm going to guess this could be from a script that merged ligatures from Fira Code.

jonboiser commented 3 years ago

This repo is a fork of the original Source Code Pro repo. You can see in a commit like this one https://github.com/i-tu/Hasklig/commit/fe063b4cc66eabfa6fb949b9fb07c26d2a555862 one of the last updates from the upstream repo.

I'm not sure how these updates were done, but it might be possible to update to the latest SCP source, and run the build scripts.

ehrlichja commented 3 years ago

I fixed this problem on my Big Sur installation. I deleted Haskling from Font Book and re-installed it using Brew.

The problem was only showing up in Alacritty for me, but the above steps fixed it.

tovbinm commented 3 years ago

@ehrlichja That did not work for me.

thedocbwarren commented 3 years ago

It doesn't work for anybody. Hasklig needs to be updated directly with the fixes to remove invalid SVG gliffs.

georgefst commented 3 years ago

Source Code Pro has removed the SVG table. I think the same fix is in order here.

If no one else steps up, I'll have a look at opening a PR porting the fix. But it might be easier for someone who already knows anything about creating fonts.

thedocbwarren commented 3 years ago

Agreed, I'm not 100% sure what is needed but can look as well.

pkq commented 3 years ago

Font development is well outside my comfort zone, but I believe this issue is resolved by #125. Until these changes are merged, you should be able to build the font from source using the SVGpatch branch and the directions in the README.md.

mbg commented 3 years ago

125 / v1.2 have resolved this issue for me on Big Sur.

i-tu commented 3 years ago

Thank you @pkq for looking into this, and thanks @mbg for confirming it works 👍

The new release can be downloaded here: https://github.com/i-tu/Hasklig/releases/tag/v1.2

Do let me know if you have any issues.

Happy winter solstice and related festivities to all! :)

jonboiser commented 3 years ago

I've submitted a PR to update the homebrew cask for this font (my preferred installation method)

https://github.com/Homebrew/homebrew-cask-fonts/pull/3301