Open i0jupiter opened 10 years ago
Great work Shine. A few notes after checking out the code:
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Thank you, @nidhi1608.
Now on to a few questions:
@nidhi1608 -- I got answers to the ActionBar questions. But it'd be great if you could tell me why a title isn't showing up on my search filters dialog.
Shine, glad you were able to get clarification on questions related to ActionBar.
For DialogFragment
title:
It looks like you are explicitly setting the dialog style to STYLE_NO_FRAME
in line 64. This removes the top and bottom borders from the dialog. You should be able to see the title if you just removed that style.
Hope that helps.
Please review my app. /cc @nesquena @thecodepath