[Android Bootcamp] Google Image Search -- Review my app

[i0jupiter]

Please review my app. /cc @nesquena @thecodepath

[nidhi1608]

Great work Shine. A few notes after checking out the code:

• Consider better organizing your source files
• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Nice to see you added the search box to the ActionBar!
• Properly used spinners (with populated values) to allow users to select filters
• Consider using String Array instead of enums to populate filter values. This helps in resource switching in case of localization.
• Good use of File object to persist the settings between activities
• Consider adding the ability to share an image. This is an important learning for this assignment even though it's optional.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[i0jupiter]

Thank you, @nidhi1608.

• Yes, I realized mid-way I should've better structured my source files. In the next assignment...
• Will look into StringArray

Now on to a few questions:

• Can you tell me why my filters dialog doesn't show a heading? I'm setting the title on line 73 in ImageSearchSettingsDialogFragment.java! I debugged quite a bit but couldn't get it to work. That's why my dialog has a "heading".
• Also, I couldn't get image sharing to work. I think I'm missing a few key things about ActionBars.
  1. Is there a single ActionBar for all activity screens or is it possible to create different action bars? I tried different ones but got all sorts of exceptions.
  2. If it's a single ActionBar with buttons for all activities, what happens when a button is clicked in the activity that doesn't handle it? For example, if the ActionBar has Search + Settings + Share, and I'm in the single image view activity, clicking on Search won't do anything. How to handle that case?
  3. Lastly, I tried adding a Share icon to my existing action bar on SearchActivity but the Share icon won't be shown. I ran out of time debugging all these issues and couldn't do the sharing part :(

[i0jupiter]

@nidhi1608 -- I got answers to the ActionBar questions. But it'd be great if you could tell me why a title isn't showing up on my search filters dialog.

[nidhi1608]

Shine, glad you were able to get clarification on questions related to ActionBar.

For DialogFragment title: It looks like you are explicitly setting the dialog style to STYLE_NO_FRAME in line 64. This removes the top and bottom borders from the dialog. You should be able to see the title if you just removed that style. Hope that helps.