i18next / i18next-browser-languageDetector

language detector used in browser environment for i18next
MIT License
865 stars 88 forks source link

Simplification of subdomain search #265

Closed handbremse closed 2 years ago

handbremse commented 2 years ago

Checklist

Checklist (for documentation change)

After thinking about it for a while, I wonder if a RegEx search is needed at all. The task of the subdomain detection is not to verify the domain view. The string "hostname" is already verified by the browser window.location. The detection should split the string and output the partial string by index (can be specified by the user). This is much faster and more robust with String.split.

What do you think?

adrai commented 2 years ago

lgtm, what about you @terhuerne ?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.