i18next / i18next-browser-languageDetector

language detector used in browser environment for i18next
MIT License
873 stars 90 forks source link

typo case miss(mix)matching in modue name #271

Closed punkratz312 closed 1 year ago

punkratz312 commented 1 year ago

i18next-browser-languagedetector i18next-browser-language-detector

image

snake-case is desired case and most common in all projects almost.

image image

its kind of easy to migrate: simply deprecate this repo and switch to a new c&p version with a new name.

adrai commented 1 year ago

Why is this a problem after so many years?

jamuhl commented 1 year ago

it's anyway i18next-specific implementation-pluginType nothing todo with casing

punkratz312 commented 1 year ago
image

its called "i18next-http-backend": "2.0.2", and not "i18next-httpbackend": "2.0.2", or "i18next-httpBackend": "2.0.2",

don´t be lazy around here whats up.

i18next-browser-languageDetector is dangling fix it to i18next-browser-language-detector

to much better to read and understand and these are 2 seperate words as you intend in cour camelCasing 🐪

so please fix it up and use what the whole internet preffesed snake-case

@adrai im see it only right now and im the qa guy in our team. i see what other people dont (want to see)

jamuhl commented 1 year ago

i18next-http-backend

-> i18next -> http (using http, request, fetch, ...) -> backend (is the plugin type)

so naming makes sense

i18next-http-backend i18next-redis-backend i18next-mongodb-backend i18next-fs-backend i18next-localstorage-backend ...

jamuhl commented 1 year ago

same also for:

i18next-{type}-postProcessor

jamuhl commented 1 year ago

beside that JS uses camelCase mostly...not snake_case

jamuhl commented 1 year ago

its kind of easy to migrate: simply deprecate this repo and switch to a new c&p version with a new name

would put a high burden on all other devs having to update their dependencies to new module...(which most won't even notice -> as it's not a automatic ncu -u)