search

i18next / i18next-browser-languageDetector

language detector used in browser environment for i18next
MIT License
865 stars 88 forks source link

addDetector type does not match implementation #282

Closed ab-pm closed 6 months ago

ab-pm commented 6 months ago

I tried to use chaining on addDetector but it didn't work.

The method is declared as https://github.com/i18next/i18next-browser-languageDetector/blob/9ad3019513beed29cbd6f070e8f6581564767e96/index.d.ts#L77-L80 but implemented as https://github.com/i18next/i18next-browser-languageDetector/blob/9ad3019513beed29cbd6f070e8f6581564767e96/src/index.js#L59-L61

Either it should be declared to return void or implemented to return this;.

adrai commented 6 months ago

addressed with v7.2.1