i18next / i18next-gettext-converter

converts gettext .mo or .po to 18next json format and vice versa
MIT License
196 stars 56 forks source link

No error thrown when error in .po file. #148

Closed jashment closed 2 years ago

jashment commented 2 years ago

When there is an issue in a translated .po file, the error isn't thrown and no information is logged about the error. This will throw the error, log it, and raise and exit code 1.

Closes #147

Checklist

No new test needed as there is already a test dedicated to throwing the same error

Checklist (for documentation change)

perrin4869 commented 2 years ago

@jashment Thanks for the PR! Could you please fix the linting errors? Thanks!

jashment commented 2 years ago

@jashment Thanks for the PR! Could you please fix the linting errors? Thanks!

Didn't catch those, fixed. Thank you!

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 97.183% when pulling 9516b0f7da3170d90ef6ca634744f3a7ecf6fe10 on jashment:master into adc0ecc44d3620dbd1477c5ac2f801454f9f72b1 on i18next:master.

perrin4869 commented 2 years ago

Thank you so much!! And sorry for the delay!