search

i18next / i18next-gitbook

165 stars 172 forks source link

Added impact on localization section to interpolation #210

Closed jennylreid closed 1 year ago

jennylreid commented 1 year ago

Checklist

Checklist (for documentation change)

jamuhl commented 1 year ago

awesome addition, well written making some of the pitfalls of inproper usage very clear...wondering if we should add an extra page to collect such samples to give the users some "best practices / possible pitfalls"

jennylreid commented 1 year ago

Thanks. I'd be happy to work on this. Bane of my existence :)

On Thu, Jun 22, 2023 at 11:20 PM Jan Mühlemann @.***> wrote:

awesome addition, well written making some of the pitfalls of inproper usage very clear...wondering if we should add an extra page to collect such samples to give the users some "best practices / possible pitfalls"

— Reply to this email directly, view it on GitHub https://github.com/i18next/i18next-gitbook/pull/210#issuecomment-1603736655, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAIV5K7N5BZGLK4IQ4AJASDXMUYRRANCNFSM6AAAAAAZQXY6OE . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Jenny Reid - LinkedIn https://www.linkedin.com/in/jennyreid/

jamuhl commented 1 year ago

added https://www.i18next.com/principles/best-practices with this content

if you got more additions to this - I'm more than happy to add them

jennylreid commented 1 year ago

That's great. Seems like I don't get credit though because you opened a new PR, am I right? I think it's ok. Just first time. Thought I'd see it update in my profile.

On Mon, Jun 26, 2023 at 8:25 AM Jan Mühlemann @.***> wrote:

added https://www.i18next.com/principles/best-practices with this content

if you got more additions to this - I'm more than happy to add them

— Reply to this email directly, view it on GitHub https://github.com/i18next/i18next-gitbook/pull/210#issuecomment-1607717424, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAIV5K55AYZYA4JKHCO2KEDXNGSWRANCNFSM6AAAAAAZQXY6OE . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Jenny Reid - LinkedIn https://www.linkedin.com/in/jennyreid/

jamuhl commented 1 year ago

This PR was closed - therefore I directly copied the content -> but you're right...I added a visible quote to the page so people can find the source of that content -> https://www.i18next.com/principles/best-practices

Hope this is ok for you?

Regarding the code contribution - as you closed the PR I couldn't add the content by merging and just copied it from the "Files changed" section. Wasn't able to reopen this PR to get it merged - as that repo was deleted...hopefully I will be able to merge your next PR (really like that kind of content helping people understand the difficulties that can get in the way)