fix variables not nullable in request callback typescript definition

i18next / i18next-http-backend

i18next-http-backend is a backend layer for i18next using in Node.js, in the browser and for Deno.

MIT License

443 stars 67 forks source link

fix variables not nullable in request callback typescript definition #143

Closed tomdardev closed 2 months ago

tomdardev commented 2 months ago

The RequestCallback type definition didn't mention that both of its parameters are nullable. This is especially confusing since the documentation explicitly mentions the response parameter as being nullable.

Checklist

[x] only relevant code is changed (make a diff before you submit the PR)
[x] run tests npm run test
[ ] tests are included
[ ] commit message and code follows the Developer's Certification of Origin

adrai commented 2 months ago

thank you... will be included in the next release