search

i18next / i18next-parser

Parse your code to extract translation keys/values and manage your catalog files
MIT License
477 stars 195 forks source link

custom contextSeparator fix #1008

Closed vseva closed 3 months ago

vseva commented 4 months ago

Why am I submitting this PR

Unused keys where words separated with underscore (for example "some_key", "some_key_just_started_likeprevious") not removed because hardcoded in helpers.js contextRegex and both "some_key" and "some_key_just_started_like_previous" treats like context forms of one key.

Does it fix an existing ticket?

No

Checklist

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.40%. Comparing base (7e14d85) to head (168c8d5). Report is 25 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1008 +/- ## ========================================== + Coverage 95.16% 95.40% +0.24% ========================================== Files 11 11 Lines 1922 1937 +15 ========================================== + Hits 1829 1848 +19 + Misses 93 89 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vseva commented 3 months ago

@karellm please look at this PR

karellm commented 3 months ago

Thank you! It is now in 9.0.0