i18next / i18next-parser

Parse your code to extract translation keys/values and manage your catalog files
MIT License
486 stars 198 forks source link

Fix plurals not being detected when count is a CallExpression #1022

Closed glsignal closed 4 months ago

glsignal commented 4 months ago

Why am I submitting this PR

Addresses https://github.com/i18next/i18next-parser/issues/1015 where the JavaScript lexer would no longer correctly identify plurals where the count was a CallExpression

Does it fix an existing ticket?

Yes #1015

Checklist

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.35%. Comparing base (168c8d5) to head (80ea05f). Report is 18 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1022 +/- ## ========================================== - Coverage 95.40% 95.35% -0.05% ========================================== Files 11 10 -1 Lines 1937 1918 -19 ========================================== - Hits 1848 1829 -19 Misses 89 89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karellm commented 4 months ago

This is now part of 9.0.1. Thanks for the PR!