Closed ripecosta closed 3 months ago
ripecosta
commented
3 months ago @karellm I raised this PR with some maintenance for the repo if you could have a quick look. Let me know if you anything isn't clear or if you'd like me to split it into smaller PRs.
I was also thinking about raising a separate PR to improve the linting config, if that ok? Nothing major, just quality of life stuff.
codecov-commenter
commented
3 months ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.35%. Comparing base (
168c8d5) to head (e1975fc). Report is 60 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
karellm
commented
3 months ago @ripecosta Thanks for the PR.
On a side note, please don't do dependency updates alongside code improvements, I prefer multiple PRs with a single focus for each PR as it makes it easier to merge.
socket-security[bot]
commented
3 months ago New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@babel/cli@7.23.9, npm/@babel/code-frame@7.23.5, npm/@babel/core@7.23.9, npm/@babel/generator@7.23.6, npm/@babel/helper-create-regexp-features-plugin@7.24.7, npm/@babel/helper-environment-visitor@7.22.20, npm/@babel/helper-function-name@7.23.0, npm/@babel/helper-hoist-variables@7.22.5, npm/@babel/helper-module-transforms@7.23.3, npm/@babel/helper-remap-async-to-generator@7.24.7, npm/@babel/helper-replace-supers@7.24.7, npm/@babel/helper-simple-access@7.22.5, npm/@babel/helper-split-export-declaration@7.22.6, npm/@babel/helper-string-parser@7.23.4, npm/@babel/helper-validator-identifier@7.22.20, npm/@babel/helper-wrap-function@7.24.7, npm/@babel/helpers@7.23.9, npm/@babel/highlight@7.23.4, npm/@babel/parser@7.23.9, npm/@babel/runtime@7.24.8, npm/@babel/template@7.23.9, npm/@babel/traverse@7.23.9, npm/@babel/types@7.23.9, npm/@jridgewell/gen-mapping@0.3.2, npm/@jridgewell/resolve-uri@3.1.0, npm/@jridgewell/set-array@1.1.2, npm/@jridgewell/sourcemap-codec@1.4.14, npm/@jridgewell/trace-mapping@0.3.17, npm/assertion-error@1.1.0, npm/braces@3.0.2, npm/browserslist@4.23.2, npm/caniuse-lite@1.0.30001641, npm/chai@4.5.0, npm/check-error@1.0.3, npm/deep-eql@4.1.3, npm/domutils@3.0.1, npm/electron-to-chromium@1.4.827, npm/fast-fifo@1.1.0, npm/fill-range@7.0.1, npm/function-bind@1.1.1, npm/has@1.0.3, npm/is-core-module@2.8.1, npm/lilconfig@3.1.1, npm/lint-staged@15.2.5, npm/listr2@8.2.1, npm/log-update@6.0.0, npm/loupe@2.3.7, npm/mocha@10.7.0, npm/node-releases@2.0.14, npm/p-event@6.0.0, npm/pathval@1.1.1, npm/prettier@3.2.5, npm/regjsgen@0.7.1, npm/resolve@1.21.1, npm/rfdc@1.3.1, npm/streamx@2.12.5, npm/yaml@2.4.5
Why am I submitting this PR
I noticed some update and maintenance PRs on the repo and decided to lend a hand. Here's a list of what this PR contains:
i18next-parseruses a feature from a dependency that's only available in the latest version (local yarn.lock) but not in the lowest version is declares (package.json). Makes it easier to understand which version the package is using without having to dig through the lockfile too.typescriptandi18nextwere not updated to avoid potential dependency mismatch issues downstream. TS especially has a tendency to cause these.chaigot a major version upgrade to v5 (changelog) - no breaking changes relevant to this project.Does it fix an existing ticket?
No.
Checklist
yarn test(see details here)