search

i18next / i18next-parser

Parse your code to extract translation keys/values and manage your catalog files
MIT License
482 stars 196 forks source link

chore: update dependabot versioning strategy #1055

Closed ripecosta closed 2 months ago

ripecosta commented 2 months ago

Why am I submitting this PR

Explicitly set Dependabot's versioning-strategy to increase (docs) to avoid the default behaviour of widening the allowed version or updating the lockfile only.

The issue this is trying to solve

The default Dependabot behaviour is to either widen the version constraint (example: ^8.0.0 becomes ^8.0.0 || ^9.0.0) or update the lockfile only. In both cases the repo's lockfile gets updated but doesn't force a dependency update downstream. This means that while this repo is testing against the latest version of a given dependency, the projects using it might be using a version of the same dependency that's much older. This can become an issue in situations where this repo uses a feature that's only available in the newer version of the dependency (or a feature that's had a significant update to its behaviour in the newer version. Tests would pass just fine but downstream projects would crash, and there issues are often hard to debug.

How it solved the issue

Dependabot's versioning strategy ensures that the version in the package.json is also updated, which means that when a new release is made that includes an updated, the downstream projects force an update of that dependency as well. This keeps the repo's versions and the downstream version's in sync, and catch dependency mismatch issues early.

Does it fix an existing ticket?

No

Checklist

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.35%. Comparing base (168c8d5) to head (1747199). Report is 60 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1055 +/- ## ========================================== - Coverage 95.40% 95.35% -0.05% ========================================== Files 11 10 -1 Lines 1937 1918 -19 ========================================== - Hits 1848 1829 -19 Misses 89 89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karellm commented 2 months ago

Thank you for the detailed explanation!