i18next / i18next-parser

Parse your code to extract translation keys/values and manage your catalog files
MIT License
488 stars 199 forks source link

improve warning message when prop variables are detected #805

Closed josh-egan closed 1 year ago

josh-egan commented 1 year ago

Why am I submitting this PR

The warning message when a component prop is assigned using a variable currently has a hardcoded value of Namespace, but this warning could be fired when any prop is extracted. This PR is to improve the warning message to indicate which prop is using a variable.

Does it fix an existing ticket?

No

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3435168) 94.09% compared to head (bf2fe7b) 94.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #805 +/- ## ======================================= Coverage 94.09% 94.09% ======================================= Files 11 11 Lines 1744 1744 ======================================= Hits 1641 1641 Misses 103 103 ``` | [Impacted Files](https://codecov.io/gh/i18next/i18next-parser/pull/805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i18next) | Coverage Δ | | |---|---|---| | [src/lexers/jsx-lexer.js](https://codecov.io/gh/i18next/i18next-parser/pull/805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i18next#diff-c3JjL2xleGVycy9qc3gtbGV4ZXIuanM=) | `98.23% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i18next). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=i18next)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

karellm commented 1 year ago

Pushed as 8.5.0