Skip extracting dynamic children in Trans components - Githubissues

i18next / i18next-parser

Parse your code to extract translation keys/values and manage your catalog files

MIT License

486 stars 198 forks source link

Skip extracting dynamic children in Trans components #862

Closed nicegamer7 closed 1 year ago

nicegamer7 commented 1 year ago

Why am I submitting this PR

While working on localizing our project, we found that components with the i18nIsDynamicList property weren't being extracted correctly. See https://react.i18next.com/latest/trans-component#using-with-lists-v10.5.0 for the documentation on this prop.

Does it fix an existing ticket?

No.

Checklist

[x] only relevant code is changed (make a diff before you submit the PR)
[x] tests are included and pass: yarn test (see details here)
[ ] documentation is changed or added

karellm commented 1 year ago

Thanks! Deployed in 8.3.0