Closed nicegamer7 closed 1 year ago
Patch coverage: 100.00%
and project coverage change: -0.01%
:warning:
Comparison is base (
d64d35a
) 93.94% compared to head (cdf7397
) 93.94%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the PR, this is deployed as 8.4.0
Thanks karellm.
Hi again! Just wanted to thank you for maintaining this project, and for responding so quick to my other PRs.
Why am I submitting this PR
This PR fixes a bug that causes us to extract the keys of Trans components with default values incorrectly.
Take the following example:
The above results in the key
{{name}}
, which is correct. However, if we add a default value, it causes us to extract the key incorrectly:The above results in a key of
Steve
, which isn't correct. The key shouldn't change when we provide a default value.Does it fix an existing ticket?
Possibly fixes #249, but I'm not sure if this is the same issue that the user was describing.
Checklist
yarn test
(see details here)